[PATCH] D39430: [clangd] formatting: don't ignore style

Raoul Wols via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 26 08:22:17 PST 2017


rwols added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:168
-  P.line = Location.getSpellingLineNumber() - 1;
-  P.character = Location.getSpellingColumnNumber();
   Range R = {P, P};
----------------
Why subtract 1 from the line here, but not from the column? When subtracting 1 from both, diagnostics appear correct in my client. I have moved this logic into `SourceLocToPosition`.


https://reviews.llvm.org/D39430





More information about the cfe-commits mailing list