[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 24 10:15:23 PST 2017


aaron.ballman added inline comments.


================
Comment at: unittests/AST/ASTImporterTest.cpp:553
+  EXPECT_TRUE(testImport("template<typename T> struct declToImport {"
+                         "  void m() { __is_pod(T); };"
+                         "};"
----------------
Drop the spurious semicolon at the end of the function definition.


================
Comment at: unittests/AST/ASTImporterTest.cpp:566
+                                         typeTraitExpr(
+                                           hasType(asString("_Bool"))
+                                           )))))))))));
----------------
Is this type actually correct for C++? I would expect that for C code, but not for C++.


https://reviews.llvm.org/D39722





More information about the cfe-commits mailing list