[PATCH] D38425: [clangd] Document highlights for clangd

[William Enright via Phabricator via cfe-commits]

Nebiroth marked 31 inline comments as done.
Nebiroth added inline comments.


================
Comment at: clangd/ClangdServer.h:291
+  /// Get document highlights for a symbol hovered on.
+  Tagged<std::vector<DocumentHighlight>> findDocumentHighlights(PathRef File,
+                                                                Position Pos);
----------------
malaperle wrote:
> can this thing fail? Should it be Expected<Tagged... ??
Oops, yeah this should be a llvm::Expected


https://reviews.llvm.org/D38425