[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 23 07:55:23 PST 2017


aaron.ballman added a comment.

In https://reviews.llvm.org/D39722#933699, @a.sidorin wrote:

> Hello Takafumi,
>
> This is almost OK to me but there is an inline comment we need to resolve in order to avoid Windows buildbot failures.
>  In addition, as Gabor pointed, when we add a new matcher, we need to update matcher documentation as well. To update the docs, you should perform just three steps.
>
> 1. Rebase your patch onto latest master
> 2. Launch script docs/tools/dump_ast_matchers.py
> 3. Add changes made by this script to your commit.


I'm a bit confused -- I don't see any ASTMatcher changes as part of this patch aside from what's in the test file. Are you suggesting the matcher there should be hoisted as a separate patch?


https://reviews.llvm.org/D39722





More information about the cfe-commits mailing list