[PATCH] Ensure std::getline always 0-terminates string.

Volodymyr Sapsai via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 22 12:03:38 PST 2017


On Nov 20, 2017, at 23:59, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> On 21.11.2017, at 03:54, Volodymyr Sapsai <vsapsai at apple.com <mailto:vsapsai at apple.com>> wrote:
>> 
>>> If (exceptions()&badbit) != 0 then the exception is rethrown.
>> And looks like libstdc++ rethrows exception even if badbit is not set.
> 
> Thanks for looking all that up, I was in a hurry.
> 
>> If you feel comfortable, I can finish exception tests myself and commit the patch. How does it sound?
> 
> That would be very welcome if you don't mind.
> I don't have much time over to spend on this most days.
> 
> Thanks,
> Reimar Döffinger

Committed in r318862 and r318863 (the latter one is my mistake). Thanks for contributing the fix.

Regards,
Volodymyr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171122/509370a4/attachment.html>


More information about the cfe-commits mailing list