[PATCH] D40276: Add -finstrument-function-entry-bare flag

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

Reid, are you happy with this too?

In https://reviews.llvm.org/D40276#931502, @pasko wrote:

> Instrumenting the function entry post-inlining, without function exit, and with no parameters is exactly what we need. The `__cyg_profile_func_enter_bare` sounds good to me as a name. Thank you!


Great!

> Unnecessary thoughts just to get a feeling we are on the same page: this could theoretically be made more orthogonal where `-finstrument-functions-after-inlining` could regulate whether the call is pre- or post-inlining, but I don't see how pre-inlining without parameters would be usable without too much DWARF digging, which is not too practical.

The way I think about them, these flags all enable separate instrumentations (though you can only enable one at a time), they don't modify eachother as I think that might end up messier for the user.

In https://reviews.llvm.org/D40276#931706, @mattcary wrote:

> It looks like there also has to be a change to llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp?


Yes, I'll land that in llvm once we're happy with this. I just wanted to make sure we get the flag and function names right, then the rest is trivial.


https://reviews.llvm.org/D40276