[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added inline comments.


================
Comment at: lib/Driver/ToolChains/Gnu.cpp:1823
+                                             "riscv64-unknown-linux-gnu",
+                                             "riscv32-unknown-elf"};
+
----------------
I suppose we need riscv64-unknown-elf here too?


================
Comment at: lib/Driver/ToolChains/Linux.cpp:228
   const bool IsHexagon = Arch == llvm::Triple::hexagon;
+  const bool IsRISCV = Arch == llvm::Triple::riscv32 || llvm::Triple::riscv64;
 
----------------
This seems incorrect. RHS should be:
```
Arch == llvm::Triple::riscv32 || Arch == llvm::Triple::riscv64;


https://reviews.llvm.org/D39963