[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please split this review with one check per review.



================
Comment at: docs/ReleaseNotes.rst:83
+
+  Check to prevent creation of  statically-stored objects in Fuchsia.
+
----------------
Please fix double space


================
Comment at: docs/clang-tidy/checks/fuchsia-default-arguments.rst:8
+
+Ex. The declaration:
+
----------------
Please don't use abbreviations. Same in other places.


================
Comment at: docs/clang-tidy/checks/fuchsia-default-arguments.rst:19
+a warning:
+.. code-block:: c++
+
----------------
Please insert empty line above.


================
Comment at: docs/clang-tidy/checks/fuchsia-statically-constructed-objects.rst:7
+Warns if statically-stored objects are created, unless constructed
+with constexpr.
+
----------------
Please highlight constexpr with ``. Same in other places.


================
Comment at: docs/clang-tidy/checks/fuchsia-thread-local.rst:6
+
+Warns if thread-local storage is used.
+
----------------
Please highlight thread-local and extern with ``. Same in other places.


Repository:
  rL LLVM

https://reviews.llvm.org/D40108