[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

[Jacob Bandes-Storch via Phabricator via cfe-commits]

jtbandes added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+  "cannot initialize object parameter of type %0 with an expression "
+  "of type %1">;
----------------
aaron.ballman wrote:
> I don't think this diagnostic needs to be moved and renamed; the old name was more clear than "other" on the new name.
How about `_bad_type`? I was hoping to give these all similar names since they happen during the same implicit conversion. Also, while "implicit object parameter" is technically a correct name, it seems to be not very commonly used and would confuse users. Though it's also valuable for the diagnostic id to be similar to the actual text...


https://reviews.llvm.org/D39937