[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 15 00:46:23 PST 2017


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits, I'd like to see whether @benhamilton has comments before committing it.



================
Comment at: docs/clang-tidy/checks/google-objc-avoid-throwing-exception.rst:4
+google-objc-avoid-throwing-exception
+=======================================
+
----------------
nit: remove the extra  `===`


================
Comment at: docs/clang-tidy/checks/google-objc-avoid-throwing-exception.rst:10
+The corresponding style guide rule:
+http://go/objc-style#Avoid_Throwing_Exceptions
----------------
Use the public link: http://google.github.io/styleguide/objcguide.html#avoid-throwing-exceptions


================
Comment at: test/clang-tidy/google-objc-avoid-throwing-exception.m:11
+ at end
+
----------------
nit: remove the empty line.


https://reviews.llvm.org/D40058





More information about the cfe-commits mailing list