[PATCH] D38708: [AST] Flag the typo-corrected nodes for better tooling

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 14 08:26:37 PST 2017


ilya-biryukov added a comment.

Sorry, not familiar enough with the AST bits yet to LGTM this.

Looks good from a higher-level perspective, though.
It's a bit of a shame that's it is still super-easy to write code that does not account for typo-corrected nodes. A more explicit approach, similar to non-canonical and sugared `Type`s, would probably be nicer, but getting there seems to be hard and may not be worth the effort.


Repository:
  rL LLVM

https://reviews.llvm.org/D38708





More information about the cfe-commits mailing list