[PATCH] D37812: [analyzer] PthreadLock: Escape the pointers.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 13 06:56:12 PST 2017


a.sidorin added a comment.

Hi Artem. The patch looks mostly good, but I have an inline question.



================
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:588
+    if (Call->isInSystemHeader())
+      IsLibraryFunction = true;
+  }
----------------
Do we think that only system headers contain library functions? Shouldn't we use `CheckerContext::isCLibraryFunction()` instead?


https://reviews.llvm.org/D37812





More information about the cfe-commits mailing list