[PATCH] D39829: add new check for property declaration

Yan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 10 16:33:54 PST 2017

Wizard marked 2 inline comments as done.
Wizard added inline comments.

Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:27
+FixItHint generateFixItHint(const ObjCPropertyDecl *Decl) {
+  if (isupper(Decl->getName()[0])) {
+    auto NewName = Decl->getName().str();
hokein wrote:
> nit: I would add an assert to make sure the name is not empty.
Added it to the line before generating the warning message.

Comment at: docs/clang-tidy/checks/google-objc-global-variable-declaration.rst:1
 .. title:: clang-tidy - google-objc-global-variable-declaration
benhamilton wrote:
> Let's remove "google-" everywhere and mention only Apple's style guide.
Discussed offline. The change here is for another doc. Irrelevant to the new check.


More information about the cfe-commits mailing list