[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 10 16:14:46 PST 2017


efriedma added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:12853
+      const llvm::Triple &Trip = Context.getTargetInfo().getTriple();
+      if ((Trip.isGNUEnvironment() || Trip.isKnownWindowsMSVCEnvironment()) &&
+          (Name->isStr("fma") || Name->isStr("fmaf") || Name->isStr("fmal") ||
----------------
isOSMSVCRT().

Please check the BuiltinID rather than using string compares.


https://reviews.llvm.org/D39641





More information about the cfe-commits mailing list