[PATCH] D38425: [clangd] Document highlights for clangd

William Enright via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 10 14:55:21 PST 2017

Nebiroth added a comment.

This updated patch still does not handle highlighting macro references correctly. I will make another patch at a later time for this issue.

In https://reviews.llvm.org/D38425#922408, @ioeric wrote:

> Drive-by comment: in general, have you considered reusing the existing declarations and occurrences finding functionalities in clang-rename? AFAIK, it deals with templates and macros pretty well.
> o https://github.com/llvm-mirror/clang/blob/master/include/clang/Tooling/Refactoring/Rename/USRFinder.h 
>  o https://github.com/llvm-mirror/clang/blob/master/include/clang/Tooling/Refactoring/Rename/USRLocFinder.h

I'll take a look at it later. Thanks!


More information about the cfe-commits mailing list