[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

Sanjay Patel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 10 11:08:28 PST 2017

spatel added a comment.

Based on the comments in https://reviews.llvm.org/D39611, I think we have to change this (although I'd be happy to be wrong).

1. cbrt() can underflow and could set errno to ERANGE.
2. fma() can overflow or underflow and set errno to ERANGE.

We could still make an exception for a GNU environment (as was drafted in https://reviews.llvm.org/D39611) if we're confident that that implementation guarantees that it won't ever set errno for these 2 functions?


More information about the cfe-commits mailing list