[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

Dean Michael Berris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 21:58:55 PST 2017

dberris added a comment.

Landing now, will deal with the test and dynamic/

Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75
-	.globl __xray_FunctionEntry
+	.globl ASM_TSAN_SYMBOL(__xray_FunctionEntry)
 	.align 16, 0x90
kubamracek wrote:
> Since we want to use `ASM_TSAN_SYMBOL` outside of TSan, can we rename it to just `ASM_SYMBOL` (or something like that)?
Probably. I was thinking about doing that, but then ended up deciding against it.

I can make a change later to migrate all uses in compiler-rt (if someone doesn't beat me to it). :)



More information about the cfe-commits mailing list