[PATCH] D39738: [clangd] Sort completion results.

Francisco Lopes da Silva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 14:42:22 PST 2017

francisco.lopes added a comment.

OK. I do agree serialization, etc, is a stumbling block on delivering large results fast. I just wanted to warn on this because I've just seen ycmd devs went through this, where sorting was one of the bottlenecks, like, to `std::sort` 43k results instead of simply partial sorting them just over a 30 results window, which is orders of magnitude faster.

If LSP completion ends up only feasible when there's filtering server side, with its own hard-coded sorting/filtering/ranking mechanisms, it's really sad, because it completely reduce flexibility of consumers wishing to apply their own (custom/configurable/uniform) sorting mechanisms.



More information about the cfe-commits mailing list