[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 23:51:18 PST 2017

ilya-biryukov added inline comments.

Comment at: clangd/ClangdServer.h:289
+  /// ChangedSettings
+  void changeConfiguration(std::map<std::string, std::string> ChangedSettings);
Nebiroth wrote:
> ilya-biryukov wrote:
> > This function is way too general for `ClangdServer`'s interface, can we have more fine-grained settings here (i.e. `setCompletionParameters` etc?) and handle the "general" case in `ClangdLSPServer` (i.e., unknown setting names, invalid setting parameters, json parsing, etc.)?
> > 
> > I suggest we remove this function altogether.
> So if I understand correctly, we would have the most generic workspace/didChangeConfiguration handler located in ClangdLSPServer
>  with a name perhaps similar to  changeConfiguration  that would pass valid settings to more specific functions inside ClangdServer ?


More information about the cfe-commits mailing list