[PATCH] D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list.

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added a comment.

I think I lack context to completely get what is going on here: I assume we don't model the assignment here?



================
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:533
 
-  if (isa<CXXConstructExpr>(Init)) {
+  if (isa<CXXConstructExpr>(Init) || isa<CXXStdInitializerListExpr>(Init)) {
     // No work needed. Just pass the value up to this expression.
----------------
Empty "if" looks weird, why not just negate the condition, and then you could get rid of "else"?


https://reviews.llvm.org/D39803