[PATCH] D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 08:13:52 PST 2017

sammccall marked an inline comment as done.
sammccall added a comment.

In https://reviews.llvm.org/D39799#919388, @ilya-biryukov wrote:

> I can see that `FixedCompilationDatabase` does not set a working directory. Is this something we may want to have for `compile_flags.txt` or one would need to resort to `compile_commands.json` to get this?
>  E.g., I'd find it useful to add includes with paths relative to `compile_flags.txt` by putting `-Iproject-dep/include` there.

Currently the working directory is always the parent of `compile_flags.txt` as you suggest.
Maybe this isn't great though - sometimes it might be important that the WD is the parent of the source file?


More information about the cfe-commits mailing list