[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

Cameron via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 07:25:41 PST 2017

cameron314 added inline comments.

Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365
                            cast<CXXMethodDecl>(FD)->getParent(), ObjectType,
-                           ObjectClassification, Args.slice(1), CandidateSet,
+                           ObjectClassification, FunctionArgs, CandidateSet,
                            SuppressUserConversions, PartialOverloading);
This breaks normal (non-static) method overload resolution, since the `this` argument is now passed to `AddMethodCandidate` which is not expecting it. It always thinks too many arguments are passed to methods with no parameters; most other calls to `AddMethodCandidate` in SemaOverload.cpp don't pass the implicit `this`.



More information about the cfe-commits mailing list