[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 04:24:17 PST 2017


ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.

Could you please take a different approach and add the callbacks you need into `PreambleCallbacks` class?
It already has this one:

  virtual void HandleMacroDefined(const Token &MacroNameTok,
                                 const MacroDirective *MD);

Otherwise we'll be creating too many ways to do the same thing.

We should also definitely get rid of all the unrelated formatting changes.


https://reviews.llvm.org/D39375





More information about the cfe-commits mailing list