[PATCH] D39611: [CodeGen] change const-ness of complex calls

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 15:24:38 PST 2017

hfinkel added a comment.

In https://reviews.llvm.org/D39611#918275, @spatel wrote:

> Patch updated:
>  I don't know if we have agreement on the behavior that we want yet,

I just sent a note to the Austin group mailing list to see if the POSIX folks agree with my reading. I'll follow up.

> but I'm updating the patch/description/title to only deal with <complex> in this patch and taking a shot at one interpretation, so we can see what that might look like.
> There are really 2 changes here:
> 1. We had all of <complex> marked constant all the time ('c'). I think there's agreement that can't be true by default (a platform could set errno on any of these calls based on the language in the C standard).
> 2. We make an exception for a GNU environment - here, the calls are always constant because the standard allows - and POSIX constrains - the errno setting behavior. This is despite the fact that glibc is known to set errno in some cases.


More information about the cfe-commits mailing list