[PATCH] D39537: Rename identifiers named `__output`

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 05:20:20 PST 2017


arichardson added inline comments.


================
Comment at: test/support/nasty_macros.hpp:55
 
+#define __output NASTY_MACRO
+#define __input NASTY_MACRO
----------------
EricWF wrote:
> Shouldn't these not be defined when running the tests with a CHER compiler? Otherwise the macro will conflict with the keyword?
It isn't being used anywhere in libcxx so that should be fine. The tests are still working for me since it doesn't seem like we are compiling with `-Werror=reserved-id-macro`.


Repository:
  rL LLVM

https://reviews.llvm.org/D39537





More information about the cfe-commits mailing list