[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 04:45:43 PST 2017

xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

This looks like a great addition! Apart from some nits, LGTM.

Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:487
+        // result >= constant
+        return Result.Intersect(BV, F, SIE->getRHS(), BV.getMaxValue(T));
Comments should be sentences (start with capital letter and have a period).

Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:498
+  return Result;
This new line is redundant. Also, there are way more new lines in this method than there usually are in LLVM.


More information about the cfe-commits mailing list