[PATCH] D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 18:29:00 PST 2017

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

I think I would prefer if this patch "left an explicit trace" as to the reasons for all the `(void)` casts. Specifically I think a macro like `TEST_IGNORE_DISCARD <expr>` might be nice.

@BillyONeal What do you think?

Otherwise this LGTM.


More information about the cfe-commits mailing list