[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 13:22:48 PST 2017

dcoughlin added inline comments.

Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:26
+/// results in an ElementRegion.
+static void conjureOffsetSymbolOnLocation(
+    SVal &Symbol, SVal Other, Expr* Expression, SValBuilder &svalBuilder,
I think it would be more clear at the call site what the inputs and output are if this function returned the conjured SVal (or 'Symbol' if it wouldn't be conjured).

It would also be good to describe the role of the parameters in the doxygen comment.


More information about the cfe-commits mailing list