[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 10:59:51 PST 2017

craig.topper added inline comments.

Comment at: lib/Headers/avx512vlbwintrin.h:2801
+  return _mm_mask_cmp_epi8_mask (__U, _mm_and_si128 (__A, __B),
+                                 _mm_setzero_hi(), 4);
craig.topper wrote:
> Sorry I didn't catch this before, but can you use _MM_CMPINT_NE and _MM_CMPINT_EQ instead of '4' and '0' in all of these? Then no one has to guess what 4 and 0 means.
Better yet, use _mm512_cmpneq_epi32_mask, __mm512_cmpeq_epi32_mask and friends


More information about the cfe-commits mailing list