[PATCH] D39631: [X86] Add 3dnow and 3dnowa to the list of valid target features

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D39631#915943, @craig.topper wrote:

> Can we just add -Werror to test/CodeGen/3dnow-builtins.c   to test this?


That file actually already has got `-Werror`

> I believe it should be throwing a warning currently.

It doesn't. That test enables the feature via `-target-feature +3dnowa` on the command line, which is accepted even if it isn't matched in `isValidFeatureName`, and the header declaration doesn't trigger any warnings.

> Can we also remove mm3dnow and mm3dnowa from the isValidFeatureName?

The clang tests seem to pass with that removed at least (and nothing in mingw-w64 seems to refer to it in that form so it should probably be fine) - I can update the patch (and retest building mingw-w64) with that change if you want it squashed.


https://reviews.llvm.org/D39631