[PATCH] D39419: Fix crash when parsing objective-c++ containing invalid lambda

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 23:51:58 PDT 2017


arphaman added inline comments.


================
Comment at: lib/Parse/ParseExprCXX.cpp:1020
 
-  PA.Commit();
-  return false;
+  PA2.Revert();
+  return true;
----------------
Just to clarify: It seems like this revert (in addition to two TPAs) is the main addition. Did we hit the assertion previously with the crash?


================
Comment at: test/Parser/objcxx11-invalid-lambda.cpp:11
+}               // expected-error{{expected ')'}} expected-error{{expected ';' at end of declaration}} expected-error{{expected '}'}}
\ No newline at end of file

----------------
Nit: missing newline.


https://reviews.llvm.org/D39419





More information about the cfe-commits mailing list