[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

Johann Klähn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 02:17:11 PDT 2017


jklaehn added a comment.

I spotted two typos. :) Also, the commit message needs to be updated.



================
Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:61
+  StringRef getDescription() const override {
+    return "The new qualified to chagne the symbol to";
+  }
----------------
There is a typo here → "qualified name to change"


================
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:105
+
+const RefactoringDescriptor &QualifiedRenameRuledescribe() {
+  static const RefactoringDescriptor Descriptor = {
----------------
missing `::`? → `::describe()`


https://reviews.llvm.org/D39332





More information about the cfe-commits mailing list