[PATCH] D39509: Vary Windows toolchain selection by -fused-ld

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 1 14:47:33 PDT 2017


smeenai added inline comments.


================
Comment at: lib/Driver/Driver.cpp:3884
+        const auto A = Args.getLastArgValue(options::OPT_fuse_ld_EQ, "link");
+        if (A.equals_lower("link") || A.equals_lower("lld"))
+          TC =
----------------
`lld-link` is a valid invocation for LLD as well, so I'd either add that option, change the equality option to a start check, or invert the check and check for an `-fuse-ld=` option starting with `bfd` (since we want the MSVC toolchain to be the default).


https://reviews.llvm.org/D39509





More information about the cfe-commits mailing list