[PATCH] D39050: Add index-while-building support to Clang

Nathan Hawes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 31 16:45:56 PDT 2017


nathawes planned changes to this revision.
nathawes added a comment.

Thanks @arphaman! I'll work through your comments and update.



================
Comment at: include/clang/Index/IndexDataStoreSymbolUtils.h:13
+
+#include "indexstore/indexstore.h"
+#include "clang/Index/IndexSymbol.h"
----------------
arphaman wrote:
> It looks to me like this header, `"indexstore/indexstore.h"`, and `IndexDataStoreUtils.cpp` are utilities just for the C API, so could we take it out of here as well?
They're used by IndexRecordWriter below to convert from libIndex's representation of things to the index store's.


https://reviews.llvm.org/D39050





More information about the cfe-commits mailing list