[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 30 08:57:33 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D39365#910713, @theraven wrote:

> Sorry - it looks as if I read the diff back to front.  I seem to be less awake than I thought today...
>
> Reading the diff the correct way around, this seems like a definite improvement.


Ok, thanks! Then it's just left to see if @rnk agrees with @compnerd 's reasoning.

>>> though the use of `PRIxPTR` vs `PRIXPTR` seems inconsistent (as is the original use of `%x` vs `%X`.
>> 
>> Yes, I've kept these as inconsistent as they were originally - if peferred I can make the ones I touch consistently either upper or lower case.
> 
> I'd generally prefer `PRIxPTR`, because most of the time I either don't care or want to copy and paste for comparison with objdump output (which uses lower case).

Ok, I'll make it consistent in the next update or when committing.


https://reviews.llvm.org/D39365





More information about the cfe-commits mailing list