[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

Yuka Takahashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 16:57:30 PDT 2017

yamaguchi added inline comments.

Comment at: clang/lib/Driver/Driver.cpp:1171
+  StringRef TargetFlag = PassedFlags;
+  for (; TargetFlag.find(':') != StringRef::npos;) {
+    StringRef CurFlag;
v.g.vassilev wrote:
> Why not a `while` loop?
I didn't have special reason, I'll change it to while if it fits better.


More information about the cfe-commits mailing list