[PATCH] D39057: [clangd][WIP] Integrate the refactoring actions into clangd

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 14:02:02 PDT 2017

arphaman added a comment.

In https://reviews.llvm.org/D39057#907820, @sammccall wrote:

> In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote:
> > There's another patch (https://reviews.llvm.org/D39276) that tries to add `workspace/executeCommand` for a slightly different use-case.
> >  Could we take the code for parsing/handling `workspace/executeCommand` from this patch and extract it into a separate change so that these two patches can be reviewed independently?
> @arphaman unless you're far down this path already, I'd actually prefer we land that patch soon and merge this one into it:
> - It's got a pretty narrow scope (1 command, not much logic), and will be ready soon. It's almost actually the isolated patch that @ilya-biryukov describes. This patch is both more general in scope and is stacked on top of other nontrivial changes, so will probably take longer.
> - It makes a couple of different decisions that I think would aid the design here, will leave detailed comments.
>   But if people prefer, we can certainly tackle command parsing separately.

Ok, I will wait until that patch lands.



More information about the cfe-commits mailing list