[PATCH] D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available

Melanie Blower via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 06:11:22 PDT 2017


mibintc updated this revision to Diff 120581.
mibintc added a comment.

The patch to clang is the same as before. The modifications are to the test cases, I verified that all these test cases need modifications. I will also be updating the associated diff for clang/tools/extra, please review that as well.  Without the test patches, these are the tests that fail (using check-all) . The failure mode is as described in a note I posted earlier this week, please let me know if you need further details.  @jyknight Looking for your review and approval, thanks!

  Clang :: Driver/crash-report-header.h
  Clang :: Driver/crash-report-spaces.c
  Clang :: Driver/crash-report.c
  Clang :: Driver/rewrite-map-in-diagnostics.c
  Clang :: Driver/stdc-predef.c
  Clang :: Index/IBOutletCollection.m
  Clang :: Index/annotate-macro-args.m
  Clang :: Index/annotate-tokens-pp.c
  Clang :: Index/annotate-tokens.c
  Clang :: Index/c-index-getCursor-test.m
  Clang :: Index/get-cursor-macro-args.m
  Clang :: Index/get-cursor.cpp
  Clang :: Preprocessor/ignore-pragmas.c
  Clang Tools :: pp-trace/pp-trace-pragma-general.cpp
  Clang Tools :: pp-trace/pp-trace-pragma-opencl.cpp
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.BasicTest1
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.BasicTest2
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.BasicTest3
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.IfBlock1
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.IfBlock2
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.IfBlock3
  Clang-Unit :: Tooling/./ToolingTests/CommentHandlerTest.PPDirectives


https://reviews.llvm.org/D34158

Files:
  include/clang/Driver/CC1Options.td
  include/clang/Lex/PreprocessorOptions.h
  lib/Driver/Job.cpp
  lib/Driver/ToolChains/Linux.cpp
  lib/Driver/ToolChains/Linux.h
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/InitPreprocessor.cpp
  test/Driver/Inputs/stdc-predef/usr/include/stdc-predef.h
  test/Driver/crash-report-header.h
  test/Driver/crash-report-spaces.c
  test/Driver/crash-report.c
  test/Driver/rewrite-map-in-diagnostics.c
  test/Driver/stdc-predef.c
  test/Driver/stdc-predef.i
  test/Index/IBOutletCollection.m
  test/Index/annotate-macro-args.m
  test/Index/annotate-tokens-pp.c
  test/Index/annotate-tokens.c
  test/Index/c-index-getCursor-test.m
  test/Index/get-cursor-macro-args.m
  test/Index/get-cursor.cpp
  test/Preprocessor/ignore-pragmas.c
  unittests/Tooling/TestVisitor.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34158.120581.patch
Type: text/x-patch
Size: 31154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171027/08dd5d75/attachment-0001.bin>


More information about the cfe-commits mailing list