[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 04:10:39 PDT 2017

sammccall added inline comments.

Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:143
+    }
+    auto USRs = getUSRsForDeclaration(ND, Context.getASTContext());
+    return tooling::createRenameAtomicChanges(
hokein wrote:
> sammccall wrote:
> > if this is a local refactor, and there are no USRs (symbol doesn't exist), is this an error that needs to be signaled somehow?
> This case should not be happened IMO. If we find the `ND`, we will rename `ND` at least.
Oops, of course. Maybe an assert?


More information about the cfe-commits mailing list