[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 03:36:55 PDT 2017

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This looks great!
Thanks for bearing with me.

Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:31
+  /// A human readable title for the refactoring.
+  StringRef Title;
nit: I think the RefactoringDescriptor literals are easier to understand if Title comes before Description, so they're terse --> verbose.

But totally up to you.

Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:66
+      "local-rename",
+      "Finds and renames symbols in code with no indexer support", "Rename"};
+  return Descriptor;
nit: please wrap before the title.

You can hint clang-format to wrap one-per-line by including a trailing comma in the init-list.



More information about the cfe-commits mailing list