[PATCH] D39281: [libunwind] Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 26 19:29:02 PDT 2017

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.

Comment at: src/DwarfInstructions.hpp:170
       const int lastReg = R::lastDwarfRegNum();
-      assert((int)CFI_Parser<A>::kMaxRegisterNumber > lastReg &&
+      assert((int)CFI_Parser<A>::kMaxRegisterNumber >= lastReg &&
              "register range too large");
Please use `static_cast` rather than the C style cast.


More information about the cfe-commits mailing list