[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 26 01:28:39 PDT 2017
ioeric added inline comments.
Comment at: include/clang/Tooling/Execution.h:76
+ void appendArgumentsAdjuster(ArgumentsAdjuster Adjuster);
> I think the argument adjuster adjustment shouldn't be part of this interface, as the argument adjusters cannot be changed in the phase in which we want the ExecutionContext to be used.
> I'd just make the argument adjusters a parameter on the constructor here (or alternatively, do not couple them in here, and just hand them around as a separate entity).
You are right. After a second thought, the adjuster here is actually only used by the executor itself (e.g. default args), and executors can maintain their own adjusters internally, so it doesn't need to be in the interface.
I've removed the adjuster interfaces from `ExecutionContext`. Action-specific adjusters can still be passed in through the `ToolExecutor::execute(...)` interface.
More information about the cfe-commits