[PATCH] D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?

[Faisal Vali via Phabricator via cfe-commits]

faisalv updated this revision to Diff 120346.
faisalv marked 4 inline comments as done.
faisalv added a comment.

Incorporated Aaron's feedback (although not sure if I caugh tall the white space issues).

Additionally, I was thinking of reordering the bits - and using UseSEHTry (this bit really makes no sense and even the chance of someone triggering its use erroneously (which can happen with the current bit if someone gives the deduction guide a body, should be zero) as my fusion bit.

I'm also not opposed to just adding a bit to the end of the FunctionDecl bit sequence.

Thanks for taking a look at the patch Aaron!


Repository:
  rL LLVM

https://reviews.llvm.org/D39166

Files:
  include/clang/AST/Decl.h
  include/clang/AST/InlineDeclMembers.h
  include/clang/Sema/Sema.h
  lib/AST/Decl.cpp
  lib/AST/DeclCXX.cpp
  lib/Parse/ParseCXXInlineMethods.cpp
  lib/Sema/SemaDecl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39166.120346.patch
Type: text/x-patch
Size: 5765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171026/ee729067/attachment.bin>