[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 25 11:49:43 PDT 2017

thakis added a comment.

Can you build some large-ish codebase (say, LLVM) with and without this patch and make sure that this doesn't measurably add to build perf? (With the warning turned on, obviously.)

Other than that, this looks good to me.

Comment at: test/SemaCXX/warn-zero-nullptr.cpp:68
+ public:
+// FIXME: this one should *NOT* warn.
+  explicit TemplateClass1(int a, T default_value = 0) {} // expected-warning{{zero as null pointer constant}} expected-warning{{zero as null pointer constant}}
Did you mean to fix this before commit?



More information about the cfe-commits mailing list