[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

Carlos Alberto Enciso via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 25 02:31:24 PDT 2017


CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D39239#905641, @probinson wrote:

> Have you tried this change against the GDB and LLDB test suites?  If they have failures then we should think about whether those tests are over-specific or whether we should put this under a tuning option.


LLDB test suite:
There are some specific tests that use enums and templates:

tools/lldb/packages/Python/lldbsuite/test/lang/cpp/template

but they cover only the case of scoped enums and are not affected by this patch. May be the LLDB test suite should be updated to cover scoped and unscoped enums.

I will check the GDB test suite and include the results.


https://reviews.llvm.org/D39239





More information about the cfe-commits mailing list