[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 25 01:32:42 PDT 2017
mstorsjo added inline comments.
Comment at: src/UnwindLevel1.c:79
"unwind_phase1(ex_ojb=%p): pc=0x%" PRIx64 ", start_ip=0x%" PRIx64
", func=%s, lsda=0x%" PRIx64 ", personality=0x%" PRIx64 "",
> compnerd wrote:
> > Please convert these to `%p` instead. The casting and conversion is kinda ... unnecessary.
> Using `%p` wouldn't work when on 32 bit systems currently, while most of these fields are defined to be `uint64_t` except for the arm ehabi case. I guess I could look at how hard it would be to switch it to uint64_t for the arm/dwarf case as well.
This part can be avoided if we consistently use unw_word_t == uint64_t, as done in D39280.
More information about the cfe-commits