[PATCH] D39064: implement __has_unique_object_representations

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 24 13:47:57 PDT 2017

erichkeane added inline comments.

Comment at: lib/AST/Type.cpp:2212-2213
+    for (const auto Base : ClassDecl->bases()) {
+      if (Base.isVirtual())
+        return false;
rnk wrote:
> OK, I guess vbases don't have a unique representation. :) What about vtable slots? Should we check isDynamic?
Dynamic types are caught by "isTriviallyCopyable" pretty early in the process.  I'll add a pair of tests to ensure that this remains the case.


More information about the cfe-commits mailing list