[PATCH] D39217: [libclang, bindings]: add spelling location

[Johann Klähn via Phabricator via cfe-commits]

jklaehn added inline comments.


================
Comment at: test/Index/annotate-tokens.c:226
 // CHECK-RANGE2: Punctuation: "." [55:5 - 55:6] UnexposedExpr=
-// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:52:1
+// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:41:9
 // CHECK-RANGE2: Punctuation: "=" [55:8 - 55:9] UnexposedExpr=
----------------
Those look like an improvement to me since the `MemberRef`s of `y` and `z` no longer refer to the same line?


================
Comment at: test/Index/c-index-getCursor-test.m:167
 // CHECK: [57:1 - 57:10] FunctionDecl=f:57:6 (Definition)
-// CHECK: [58:4 - 58:8] VarDecl=my_var:58:8 (Definition)
+// CHECK: [58:4 - 58:8] VarDecl=my_var:2:1 (Definition)
 // CHECK: [58:8 - 58:15] macro expansion=CONCAT:55:9
----------------
This does not seem to refer to a valid location? (line 2 only contains a comment)


https://reviews.llvm.org/D39217