[PATCH] D39218: [WebAssembly] Include libclang_rt.builtins in the standard way

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 24 10:12:17 PDT 2017

sbc100 added inline comments.

Comment at: lib/Driver/ToolChain.cpp:318
+  else
+    OSLibName = getOS();
   llvm::sys::path::append(Path, "lib", OSLibName);
dschuff wrote:
> Is this logic intended to replace what was removed from CommonArgs.cpp? Should there be an assert here too?
Just didn't see the point of that assert.  Can you see what the intention might be?  I don't see why AddRunTimeLibs() should be callable for any/all triples, do you?  I would have had to add  llvm::Triple::Unknown to the list of supported OSs, which seemed strange.


More information about the cfe-commits mailing list