[PATCH] D38982: [refactor] Initial outline of implementation of "extract function" refactoring

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

Lgtm



================
Comment at: include/clang/Basic/DiagnosticRefactoringKinds.td:24
+  "not overlap with the AST nodes of interest">;
+
+def err_refactor_code_outside_of_function : Error<"the selected code is not a "
----------------
nit: was this newline intended?


================
Comment at: tools/clang-refactor/TestSupport.cpp:370
+                                               EndColumn);
+    } else
+      EndOffset = Offset;
----------------
nit: curly braces in else-branch if if-branch has braces.


Repository:
  rL LLVM

https://reviews.llvm.org/D38982